Skip to content
Snippets Groups Projects
  1. Mar 29, 2021
  2. Mar 28, 2021
    • Nyholm's avatar
      minor #40608 [Filesystem] Fix dumpFile() method call (sebpacz) · 77870a5c
      Nyholm authored
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Filesystem] Fix dumpFile() method call
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | ?
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | ---
      | License       | MIT
      | Doc PR        | ---
      
      The dumpFile() method in the Filesystem component takes two arguments (filename and content). I found a test with the third argument set to null.
      
      Commits
      -------
      
      2b33d4af [Filesystem] Fix dumpFile() method call
      77870a5c
    • sebpacz's avatar
      [Filesystem] Fix dumpFile() method call · 2b33d4af
      sebpacz authored
      2b33d4af
    • Christian Flothmann's avatar
      minor #40606 [Form] skip intl dependent tests if the extension is missing (xabbuh) · 1a272919
      Christian Flothmann authored
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Form] skip intl dependent tests if the extension is missing
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? | no
      | Tickets       |
      | License       | MIT
      | Doc PR        |
      
      Commits
      -------
      
      71da904d skip intl dependent tests if the extension is missing
      1a272919
    • Christian Flothmann's avatar
    • Fabien Potencier's avatar
      bug #40598 [Form] error if the input string couldn't be parsed as a date (xabbuh) · 5666a45a
      Fabien Potencier authored
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Form] error if the input string couldn't be parsed as a date
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | Fix #40597
      | License       | MIT
      | Doc PR        |
      
      When the Intl polyfill is used instead of the PHP intl extension, the
      intl_get_error_code() function always returns 0 no matter if the input
      string could be parsed.
      
      Commits
      -------
      
      5ce5300d error if the input string couldn't be parsed as a date
      5666a45a
    • Fabien Potencier's avatar
      bug #40587 [HttpClient] fix using stream_copy_to_stream() with responses cast... · 9889c492
      Fabien Potencier authored
      bug #40587 [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams (nicolas-grekas)
      
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | Fix #40574
      | License       | MIT
      | Doc PR        | -
      
      Commits
      -------
      
      cf1404a3 [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams
      9889c492
  3. Mar 27, 2021
  4. Mar 26, 2021
  5. Mar 25, 2021
  6. Mar 24, 2021
    • Nicolas Grekas's avatar
      minor #40568 Fix Trying to clone an uncloneable object of class (jderusse) · 16f3fc1e
      Nicolas Grekas authored
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      Fix Trying to clone an uncloneable object of class
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | -
      | License       | MIT
      | Doc PR        | -
      
      Since `ext-redis: 5.3..3`, the `\Redis` class is not cloneable anymore (https://github.com/phpredis/phpredis/commit/cd05a344).
      PHPUnit 7.5 (used byt PHP 7.1) clones objects provided by the dataprovier, when they are cloneable.
      To check if an object is cloneable, it use the `Reflexion::isCloneable` method and check if the `__clone` method is public.
      
      The issue is, the Class generated by `createMock` is cloneable, which leads to an exception such as:
      > Trying to clone an uncloneable object of class Mock_Redis_b2f171b3
      
      This PR fake replaces the mock by a real instance of the class.
      
      Commits
      -------
      
      f67dab95 FIx Trying to clone an uncloneable object of class
      16f3fc1e
    • Jérémy Derussé's avatar
  7. Mar 23, 2021
Loading