- Mar 29, 2021
-
-
Fabien Potencier authored
released v4.4.21
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
- Mar 28, 2021
-
-
Nyholm authored
This PR was merged into the 4.4 branch. Discussion ---------- [Filesystem] Fix dumpFile() method call | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | ? | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- The dumpFile() method in the Filesystem component takes two arguments (filename and content). I found a test with the third argument set to null. Commits ------- 2b33d4af [Filesystem] Fix dumpFile() method call
-
sebpacz authored
-
Christian Flothmann authored
This PR was merged into the 4.4 branch. Discussion ---------- [Form] skip intl dependent tests if the extension is missing | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- 71da904d skip intl dependent tests if the extension is missing
-
Christian Flothmann authored
-
Fabien Potencier authored
This PR was merged into the 4.4 branch. Discussion ---------- [Form] error if the input string couldn't be parsed as a date | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40597 | License | MIT | Doc PR | When the Intl polyfill is used instead of the PHP intl extension, the intl_get_error_code() function always returns 0 no matter if the input string could be parsed. Commits ------- 5ce5300d error if the input string couldn't be parsed as a date
-
Fabien Potencier authored
bug #40587 [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40574 | License | MIT | Doc PR | - Commits ------- cf1404a3 [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams
-
- Mar 27, 2021
-
-
Nyholm authored
This PR was merged into the 4.4 branch. Discussion ---------- [VarDumper] make DateCaster tests timezone-agnostic | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- bfef4546 make DateCaster tests timezone-agnostic
-
Christian Flothmann authored
-
Christian Flothmann authored
When the Intl polyfill is used instead of the PHP intl extension, the intl_get_error_code() function always returns 0 no matter if the input string could be parsed.
-
- Mar 26, 2021
-
-
Christian Flothmann authored
This PR was merged into the 4.4 branch. Discussion ---------- [Form] IntegerType: Always use en for IntegerToLocalizedStringTransformer Fixes #40456 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40456 | License | MIT Commits ------- 83b836db IntegerType: Always use en for IntegerToLocalizedStringTransformer Fixes #40456
-
Warxcell authored
Fixes #40456
-
Robin Chalas authored
bug #40593 Uses the correct assignment action for console options depending if they are short or long (topikito) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Uses the correct assignment action for console options depending if they are short or long | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40590 | License | MIT | Doc PR | - Checks if the option is short or long, and assigns the corresponding "glue" for the assignment. Commits ------- d0a3c538 Uses the correct assignment action for console options depending if they are short or long
-
Roberto Nygaard authored
-
- Mar 25, 2021
-
-
Nyholm authored
bug #40535 [HttpKernel] ConfigDataCollector to return known data without the need of a Kernel (topikito) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [HttpKernel] ConfigDataCollector to return known data without the need of a Kernel | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40534 | License | MIT | Doc PR | Sets `$this->data` with information that can be known without the need of a `Kernel`. Commits ------- d919f2ce [HttpKernel] ConfigDataCollector to return known data without the need of a Kernel
-
Roberto Nygaard authored
-
Nicolas Grekas authored
-
- Mar 24, 2021
-
-
Nicolas Grekas authored
This PR was merged into the 4.4 branch. Discussion ---------- Fix Trying to clone an uncloneable object of class | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Since `ext-redis: 5.3..3`, the `\Redis` class is not cloneable anymore (https://github.com/phpredis/phpredis/commit/cd05a344). PHPUnit 7.5 (used byt PHP 7.1) clones objects provided by the dataprovier, when they are cloneable. To check if an object is cloneable, it use the `Reflexion::isCloneable` method and check if the `__clone` method is public. The issue is, the Class generated by `createMock` is cloneable, which leads to an exception such as: > Trying to clone an uncloneable object of class Mock_Redis_b2f171b3 This PR fake replaces the mock by a real instance of the class. Commits ------- f67dab95 FIx Trying to clone an uncloneable object of class
-
Jérémy Derussé authored
-
- Mar 23, 2021
-
-
Nicolas Grekas authored
This PR was merged into the 4.4 branch. Discussion ---------- [travis] remove cache of composer.lock for deps=low | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Let's hope that Composer 2 made this fast enough. Maintaining this script might not be worth it anymore. Reverts #28146 Commits ------- 9ba015d2 [travis] remove cache of composer.lock for deps=low
-
Nicolas Grekas authored
This PR was merged into the 4.4 branch. Discussion ---------- [Filesystem] Fix comment with typo | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Commits ------- 96a05daf Fix comment with typo
-
Nicolas Grekas authored
-
sebpacz authored
-
Nicolas Grekas authored
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] fix reported class when deprecated method is static | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- aa80df60 fix reported class when deprecated method is static
-
Christian Flothmann authored
-
Nicolas Grekas authored
This PR was merged into the 4.4 branch. Discussion ---------- [travis] use packagist API v2 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- af43ca08 [travis] use packagist API v2
-
Nicolas Grekas authored
-
Nicolas Grekas authored
This PR was merged into the 4.4 branch. Discussion ---------- [Translation] Fix update existing key with existing +int-icu domain | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none Using php-translation webui interface, I was trying to update an existing +int-icu domain but a regular domain was created and the existing key wasn't updated. Looks like in the method I modified, we should have been looking for a potential domain+intl-icu domain and try update it first Commits ------- 2a196ca0 [translation] Fix update existing key with existing +int-icu domain
-
Alexis authored
-
Robin Chalas authored
This PR was merged into the 4.4 branch. Discussion ---------- [Contracts] Fix branch name in README.md links | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- c5c47f11 [Contracts] Fix branch name in README.md links
-
Robin Chalas authored
-
Nicolas Grekas authored
This PR was merged into the 4.4 branch. Discussion ---------- [Security] Handle properly 'auto' option for remember me cookie security | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40471 | License | MIT | Doc PR | n/a Manually setting remember_me cookie secure as auto is still is being set as secure one even if used over http. This PR fixes this behaviour by converting auto to null prior setting it up for service. Commits ------- 2bcf69c0 [Security] Handle properly 'auto' option for remember me cookie security
-
Nicolas Grekas authored
-
Nicolas Grekas authored
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Validator] Avoid triggering the autoloader for user-input values | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Following-up to https://twitter.com/seldaek/status/1372450636361502721 - mostly to see if the build passes or if this breaks some undocumented/unclear-to-me assumptions. Essentially using the `Valid` constraint should only validate objects if they exist as objects. If a user sends a string and that gets assigned to a property, `Valid` should not attempt autoloading that user-given string. As far as I can tell, this is used in two places: - https://github.com/symfony/symfony/blob/acb32dd396e95967990f004953e5a480cd507e51/src/Symfony/Component/Validator/Validator/RecursiveContextualValidator.php#L364-L365 where non-objects are anyway ignored, so this change is harmless there. - https://github.com/symfony/symfony/blob/acb32dd396e95967990f004953e5a480cd507e51/src/Symfony/Component/Validator/Validator/RecursiveContextualValidator.php#L652-L660 where it's explicitly passing anything in there to get the proper exception, so my change makes sure that exception is thrown *before* autoloading attempts. I am just not 100% sure if there are cases where validateGenericNode will receive a class name as a string to validate in $value. I can't imagine why it would but that doesn't mean it's true. Commits ------- e45eb23b [Validator] Avoid triggering the autoloader for user-input values
-
Jordi Boggiano authored
-
Nicolas Grekas authored
This PR was merged into the 4.4 branch. Discussion ---------- Security Hardening - unserialize DumpDataCollector | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 214dbfec Hardening Security - Unserialize DumpDataCollector
-
Jérémy Derussé authored
-