Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
  1. Jul 29, 2021
  3. Jul 27, 2021
  5. Jul 26, 2021
  7. Jul 25, 2021
    • Fabien Potencier's avatar
      minor #42233 [Console] mark as skip test testTraversableMultiselectAutocomplete for Windows (a1812) · 38bbe02b
      Fabien Potencier authored 
      This PR was merged into the 4.4 branch.

Discussion
----------

[Console] mark as skip test testTraversableMultiselectAutocomplete for Windows

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  |no
| Deprecations? | no
| Tickets       | Fix #...
| License       | MIT
| Doc PR        |

I think that in tests we need to adhere to one style, if we skip tests with "stty", then this one needs to be skipped or unchecked from all the others.

```cmd
C:\symfony>C:\php\7.1.3\php.exe C:\symfony\phpunit --color=never --bootstrap C:\symfony\vendor\autoload.php --configuration C:\symfony\phpunit.xml.dist src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
#!/usr/bin/env php
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Testing Symfony\Component\Console\Tests\Helper\QuestionHelperTest
....SSSSSSSSSSSS..................................SSF             53 / 53 (100%)

Time: 912 ms, Memory: 8.00 MB

There was 1 failure:

1) Symfony\Component\Console\Tests\Helper\QuestionHelperTest::testTraversableMultiselectAutocomplete
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'FooBundle'
+    0 => 'AcmeDemoBundle'
+    1 => 'AsseticBundle'
 )

C:\symfony\src\Symfony\Component\Console\Tests\Helper\QuestionHelperTest.php:864

FAILURES!
Tests: 53, Assertions: 72, Failures: 1, Skipped: 14.
`

Commits
-------

6272c4b0 skip test
      38bbe02b
    • Nyholm's avatar
      minor #42252 [Validator] Added missing translations for Croatian (hr) (HypeMC) · a5752e09
      Nyholm authored 
      This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] Added missing translations for Croatian (hr)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #41816
| License       | MIT
| Doc PR        | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->

Commits
-------

e218a315 Add missing validators translation
      a5752e09
  9. Jul 24, 2021
  11. Jul 23, 2021
    • Nicolas Grekas's avatar
      minor #42247 [5.2] Add missing ``@return`` annotations (nicolas-grekas) · 74d99ae0
      Nicolas Grekas authored 
      This PR was merged into the 5.2 branch.

Discussion
----------

[5.2] Add missing ``@return`` annotations

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Same as #42246 for 5.2

Commits
-------

7c10e093 [5.2] Add missing ``@return`` annotations
      74d99ae0