Skip to content
Snippets Groups Projects
Select Git revision
0 results

symfony

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Fabien Potencier authored
    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10849).
    
    Discussion
    ----------
    
    [WIP][Finder] Fix wrong implementation on sortable callback comparator
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | no
    
    Working on this issue, i find SORT_BY_ACCESSED_TIME, SORT_BY_CHANGED_TIME, SORT_BY_MODIFIED_TIME was not tested.
    
    - [x] Add test for SORT_BY_ACCESSED_TIME case
    - [x] Add test for SORT_BY_CHANGED_TIME case
    - [x] add test for SORT_BY_MODIFIED_TIME case
    
    Commits
    -------
    
    b965fa23 [WIP][Finder] Fix wrong implementation on sortable callback comparator
    2723e447
    History
    Name Last commit Last update