Skip to content
Snippets Groups Projects
Select Git revision
  • 5.4
  • 4.4
  • 6.1 default protected
  • 6.0
  • 5.3
  • 3.4
  • 5.2
  • 5.1
  • 5.0
  • 4.3
  • 4.2
  • 2.8
  • 4.1
  • 2.7
  • 4.0
  • 3.3
  • 3.2
  • 3.1
  • 3.0
  • 2.3
  • v6.0.6
  • v5.4.6
  • v4.4.39
  • v5.3.16
  • v6.0.5
  • v5.4.5
  • v4.4.38
  • v6.0.4
  • v5.4.4
  • v5.3.15
  • v6.0.3
  • v5.4.3
  • v5.3.14
  • v4.4.37
  • v6.0.2
  • v5.4.2
  • v5.3.13
  • v4.4.36
  • v6.0.1
  • v5.4.1
40 results

symfony

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Tobias Schultze authored
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Ignore missing translation dependency in FrameworkBundle
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    This applies the fix from #31156 to the validator.xml file. The error came up a couple of times in the test suite for DoctrineBundle. When using `symfony/framework-bundle` with `symfony/validator` installed but without `symfony/translation`, the call to `setTranslator` will error out because of the missing `translator` service. Thus, the call to `setTranslator` needs to ignore a missing translator dependency to support this scenario.
    
    I don't know how to best test this since the translation component is present in the `require-dev` directive of FrameworkBundle's `composer.json`. If you have any suggestions how to achieve this, please let me know.
    
    Commits
    -------
    
    19eb90d8 Ignore missing translation dependency in FrameworkBundle
    bfe4e167
    History
    Name Last commit Last update